Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wasm c str memory alloc on the end \0 char #142

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix: wasm c str memory alloc on the end \0 char #142

merged 1 commit into from
Sep 10, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Sep 10, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • fix: wasm c str memory alloc on the end \0 char

@Peefy Peefy force-pushed the fix-wasm-c-str-mem-alloc branch from 5cf9001 to 008b6cb Compare September 10, 2024 08:45
He1pa
He1pa approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit ff53e25 into kcl-lang:main Sep 10, 2024
4 checks passed
@Peefy Peefy deleted the fix-wasm-c-str-mem-alloc branch September 10, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@He1pa He1pa He1pa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Peefy @He1pa