Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: joined string and missing key recovery for better error messages. #551

Merged
merged 1 commit into from
May 16, 2023

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented May 16, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

refactor: joined string and missing key recovery for better error messages.

2. What is the scope of this PR (e.g. component or file name):

  • kclvm/sema/src/resolver/config.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

refactor: joined string and missing key recovery for better error messages.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/types/interpolation/interpolation_0/main.k
  • test/grammar/types/interpolation/interpolation_1/main.k

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added the resolver label May 16, 2023
@Peefy Peefy added this to the v0.5.0 Release milestone May 16, 2023
@coveralls
Copy link
Collaborator

coveralls commented May 16, 2023

Pull Request Test Coverage Report for Build 4989256068

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 31 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-20.2%) to 67.789%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/config.rs 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 31 50.0%
Totals Coverage Status
Change from base Build 4976255280: -20.2%
Covered Lines: 30489
Relevant Lines: 44976

💛 - Coveralls

@Peefy Peefy requested review from SparkYuan, NeverRaR, He1pa and zong-zhe and removed request for SparkYuan May 16, 2023 08:56
@Peefy Peefy self-assigned this May 16, 2023
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 51e56a7 into kcl-lang:main May 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants