Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : support list/dict subscript format in KCL string #331

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

NeverRaR
Copy link
Contributor

@NeverRaR NeverRaR commented Dec 8, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix #149

2. What is the scope of this PR (e.g. component or file name):

kclvm/runtime/src/value/val_fmt.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@NeverRaR NeverRaR requested review from Peefy and chai2010 December 8, 2022 10:09
@Peefy Peefy added this to the v0.4.5 Release milestone Dec 8, 2022
@Peefy Peefy added the runtime Issues or PRs related to kcl runtime including value and value opertions label Dec 8, 2022
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Dec 8, 2022

Pull Request Test Coverage Report for Build 3647876726

  • 21 of 22 (95.45%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-26.4%) to 63.331%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/value/val_fmt.rs 21 22 95.45%
Totals Coverage Status
Change from base Build 3616626849: -26.4%
Covered Lines: 20775
Relevant Lines: 32804

💛 - Coveralls

Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit c9ccfc5 into kcl-lang:main Dec 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
runtime Issues or PRs related to kcl runtime including value and value opertions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support list subscript format in KCL string like python.
4 participants