Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jsonschema allof validations #372

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 19, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

Closes #212

@coveralls
Copy link

coveralls commented Aug 19, 2024

Pull Request Test Coverage Report for Build 10453133596

Details

  • 41 of 113 (36.28%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 32.314%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/tools/gen/genkcl_jsonschema.go 41 113 36.28%
Totals Coverage Status
Change from base Build 10451161718: -0.05%
Covered Lines: 5633
Relevant Lines: 17432

💛 - Coveralls

@Peefy Peefy force-pushed the jsonschema-allof-validations branch from 9c0c792 to 94aec34 Compare August 19, 2024 12:14
Copy link

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit ea9c7a5 into kcl-lang:main Aug 19, 2024
11 checks passed
@Peefy Peefy deleted the jsonschema-allof-validations branch August 19, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add AllOf validations for KCL jsonschema generations support Go API for GetSchemaTypeMapping
3 participants