Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: runtime init panic #354

Merged
merged 2 commits into from
Jul 26, 2024
Merged

fix: runtime init panic #354

merged 2 commits into from
Jul 26, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jul 24, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix: kcl-lang/cli#114

  • fix: runtime init panic

@coveralls
Copy link

coveralls commented Jul 24, 2024

Pull Request Test Coverage Report for Build 10112128318

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • 351 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.8%) to 31.734%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kcl/service.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/kcl/service.go 2 0.0%
pkg/runtime/proc.go 3 47.14%
pkg/kcl/hook.go 4 0.0%
pkg/kcl/type.go 33 0.0%
pkg/kcl/opt.go 60 26.87%
pkg/spec/gpyrpc/gpyrpc.pb.protorpc.go 104 1.22%
pkg/kcl/api.go 145 0.0%
Totals Coverage Status
Change from base Build 10077008292: -0.8%
Covered Lines: 5488
Relevant Lines: 17294

💛 - Coveralls

@Peefy Peefy force-pushed the fix-runtime-init-panic branch 9 times, most recently from 1c84e20 to 4aaddd9 Compare July 26, 2024 12:26
@Peefy Peefy force-pushed the fix-runtime-init-panic branch from 67b1cdc to f1610dd Compare July 26, 2024 13:26
@Peefy Peefy merged commit fd00ef8 into kcl-lang:main Jul 26, 2024
10 of 12 checks passed
@Peefy Peefy deleted the fix-runtime-init-panic branch July 26, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KCL panics when trying to write files that are being watched support Go API for GetSchemaTypeMapping
2 participants