Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric 'rabbitmq_up' #11

Merged
merged 1 commit into from
Sep 2, 2016
Merged

Add metric 'rabbitmq_up' #11

merged 1 commit into from
Sep 2, 2016

Conversation

wndhydrnt
Copy link

The new metric exposes whether the last scrape of RabbitMQ was
successful. It is inspired by the haproxy_exporter which exposes the
metric haproxy_up.
The value of rabbitmq_up is either 1 or 0. It can be used to
determine whether the RabbitMQ process being scraped is up-and-running.

In order to be able to set the metric, some functions have been
rewritten to return error values instead of using callbacks.

The new metric exposes whether the last scrape of RabbitMQ was
successful. It is inspired by the haproxy_exporter which exposes the
metric `haproxy_up`.
The value of `rabbitmq_up` is either `1` or `0`. It can be used to
determine whether the RabbitMQ process being scraped is up-and-running.

In order to be able to set the metric, some functions have been
rewritten to return error values instead of using callbacks.
@wndhydrnt
Copy link
Author

PTAL @kbudde

@kbudde kbudde self-assigned this Aug 30, 2016
@kbudde
Copy link
Owner

kbudde commented Aug 30, 2016

Hi,
I had a first look.
It looks good but I'm unsure if it was a good idea to remove the build function.
I will do more tests to be sure.

BR

@kbudde kbudde merged commit 330f93b into kbudde:master Sep 2, 2016
@kbudde
Copy link
Owner

kbudde commented Sep 2, 2016

Testing done. Everything is ok.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants