Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): replace optimist on yargs lib #3451

Merged
merged 1 commit into from
Mar 30, 2020
Merged

fix(server): replace optimist on yargs lib #3451

merged 1 commit into from
Mar 30, 2020

Conversation

anthony-redFox
Copy link
Contributor

@anthony-redFox anthony-redFox commented Mar 25, 2020 •
edited
Loading

fix #2473

@karmarunnerbot
Copy link
Member

✅ Build karma 138 completed (commit b439e2a46a by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 139 completed (commit fca1c3471d by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 140 completed (commit 34ded43813 by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 139 completed (commit 64154120b9 by @anthony-redFox)

@AppVeyorBot
Copy link

✅ Build karma 2537 completed (commit b439e2a46a by @anthony-redFox)

@AppVeyorBot
Copy link

✅ Build karma 2538 completed (commit 64154120b9 by @anthony-redFox)

johnjbarton
johnjbarton reviewed Mar 25, 2020
View reviewed changes
Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You marked this as BREAKING but the code looks like a refactoring to use yargs.
How can this break users?

@Ionaru Ionaru mentioned this pull request Mar 26, 2020
Closed
@codesandtags
Copy link

Hi guys, do you have any update on this PR?. I'm guessing many people and companies have that security issue reported by blackduck and other security scan tools. So that, I would like to know how can we proceed with this merged and what risk are identified.

Cheers!

@anthony-redFox
Copy link
Contributor Author

You marked this as BREAKING but the code looks like a refactoring to use yargs.
How can this break users?

@johnjbarton agree with you, update message.

@karmarunnerbot
Copy link
Member

✅ Build karma 141 completed (commit c47e932ca7 by @anthony-redFox)

@AppVeyorBot
Copy link

✅ Build karma 2540 completed (commit c47e932ca7 by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 142 completed (commit c47e932ca7 by @anthony-redFox)

@AppVeyorBot
Copy link

✅ Build karma 2541 completed (commit edd3152c1f by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 143 completed (commit fef0115e84 by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 142 completed (commit edd3152c1f by @anthony-redFox)

@johnjbarton johnjbarton merged commit ec1e69a into karma-runner:master Mar 30, 2020
@philmayfield philmayfield mentioned this pull request Apr 1, 2020
Closed
@Den-dp Den-dp mentioned this pull request Apr 1, 2020
Closed
@franktopel franktopel mentioned this pull request Apr 6, 2020
Open
This was referenced Apr 6, 2020
Merged
Closed
@peaBerberian peaBerberian mentioned this pull request Apr 7, 2020
Merged
karmarunnerbot pushed a commit that referenced this pull request Apr 9, 2020
@semantic-release-bot
chore(release): 5.0.0 [skip ci]
1b48637 
# [5.0.0](v4.4.1...v5.0.0) (2020-04-09)

### Bug Fixes

* install semantic-release as a regular dev dependency ([#3455](#3455)) ([1eaf35e](1eaf35e))
* **ci:** echo travis env that gates release after_success ([#3446](#3446)) ([b8b2ed8](b8b2ed8))
* **ci:** poll every 10s to avoid rate limit. ([#3388](#3388)) ([91e7e00](91e7e00))
* **middleware/runner:** handle file list rejections ([#3400](#3400)) ([80febfb](80febfb)), closes [#3396](#3396) [#3396](#3396)
* **server:** cleanup import of the removed method ([#3439](#3439)) ([cb1bcbf](cb1bcbf))
* **server:** createPreprocessor was removed ([#3435](#3435)) ([5c334f5](5c334f5))
* **server:** detection new MS Edge Chromium ([#3440](#3440)) ([7166ce2](7166ce2))
* **server:** replace optimist on yargs lib ([#3451](#3451)) ([ec1e69a](ec1e69a)), closes [#2473](#2473)
* **server:** Report original error message ([#3415](#3415)) ([79ee331](79ee331)), closes [#3414](#3414)

### Code Refactoring

* use native Promise instead of Bluebird ([#3436](#3436)) ([33a069f](33a069f)), closes [/github.com//pull/3060#discussion_r284797390](https://github.com//github.com/karma-runner/karma/pull/3060/issues/discussion_r284797390)

### Continuous Integration

* drop node 8, adopt node 12 ([#3430](#3430)) ([a673aa8](a673aa8))

### Features

* **docs:** document `DEFAULT_LISTEN_ADDR` constant ([#3443](#3443)) ([057d527](057d527)), closes [#2479](#2479)
* **karma-server:** added log to the server.js for uncaught exception ([#3399](#3399)) ([adc6a66](adc6a66))
* **preprocessor:** obey Pattern.isBinary when set ([#3422](#3422)) ([708ae13](708ae13)), closes [#3405](#3405)

### BREAKING CHANGES

* Karma plugins which rely on the fact that Karma uses Bluebird promises may break as Bluebird-specific API is no longer available on Promises returned by the Karma core
* **server:** Deprecated createPreprocessor removed, karma-browserify < 7 version doesn't work
* no more testing on node 8.
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nfelt nfelt mentioned this pull request Apr 14, 2020
Closed
@karronoli karronoli mentioned this pull request Aug 16, 2022
Merged
anthony-redFox added a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
@anthony-redFox
fix(server): replace optimist on yargs lib (karma-runner#3451)
a922c40 
fix karma-runner#2473
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
@semantic-release-bot @anthony-redFox
chore(release): 5.0.0 [skip ci]
d4e245c 
# [5.0.0](karma-runner/karma@v4.4.1...v5.0.0) (2020-04-09)

### Bug Fixes

* install semantic-release as a regular dev dependency ([karma-runner#3455](karma-runner#3455)) ([1eaf35e](karma-runner@1eaf35e))
* **ci:** echo travis env that gates release after_success ([karma-runner#3446](karma-runner#3446)) ([b8b2ed8](karma-runner@b8b2ed8))
* **ci:** poll every 10s to avoid rate limit. ([karma-runner#3388](karma-runner#3388)) ([91e7e00](karma-runner@91e7e00))
* **middleware/runner:** handle file list rejections ([karma-runner#3400](karma-runner#3400)) ([80febfb](karma-runner@80febfb)), closes [karma-runner#3396](karma-runner#3396) [karma-runner#3396](karma-runner#3396)
* **server:** cleanup import of the removed method ([karma-runner#3439](karma-runner#3439)) ([cb1bcbf](karma-runner@cb1bcbf))
* **server:** createPreprocessor was removed ([karma-runner#3435](karma-runner#3435)) ([5c334f5](karma-runner@5c334f5))
* **server:** detection new MS Edge Chromium ([karma-runner#3440](karma-runner#3440)) ([7166ce2](karma-runner@7166ce2))
* **server:** replace optimist on yargs lib ([karma-runner#3451](karma-runner#3451)) ([ec1e69a](karma-runner@ec1e69a)), closes [karma-runner#2473](karma-runner#2473)
* **server:** Report original error message ([karma-runner#3415](karma-runner#3415)) ([79ee331](karma-runner@79ee331)), closes [karma-runner#3414](karma-runner#3414)

### Code Refactoring

* use native Promise instead of Bluebird ([karma-runner#3436](karma-runner#3436)) ([33a069f](karma-runner@33a069f)), closes [/github.com/karma-runner/pull/3060#discussion_r284797390](https://github.com//github.com/karma-runner/karma/pull/3060/issues/discussion_r284797390)

### Continuous Integration

* drop node 8, adopt node 12 ([karma-runner#3430](karma-runner#3430)) ([a673aa8](karma-runner@a673aa8))

### Features

* **docs:** document `DEFAULT_LISTEN_ADDR` constant ([karma-runner#3443](karma-runner#3443)) ([057d527](karma-runner@057d527)), closes [karma-runner#2479](karma-runner#2479)
* **karma-server:** added log to the server.js for uncaught exception ([karma-runner#3399](karma-runner#3399)) ([adc6a66](karma-runner@adc6a66))
* **preprocessor:** obey Pattern.isBinary when set ([karma-runner#3422](karma-runner#3422)) ([708ae13](karma-runner@708ae13)), closes [karma-runner#3405](karma-runner#3405)

### BREAKING CHANGES

* Karma plugins which rely on the fact that Karma uses Bluebird promises may break as Bluebird-specific API is no longer available on Promises returned by the Karma core
* **server:** Deprecated createPreprocessor removed, karma-browserify < 7 version doesn't work
* no more testing on node 8.
This was referenced Jan 1, 2024
Open
Open
@Omrisnyk Omrisnyk mentioned this pull request Feb 2, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Feb 11, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Mar 15, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request May 28, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Jun 19, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Jul 2, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Oct 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnjbarton johnjbarton johnjbarton approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move cli to yargs
5 participants
@anthony-redFox @karmarunnerbot @AppVeyorBot @codesandtags @johnjbarton