Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(launcher): use class syntax #3437

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

devoto13
Copy link
Collaborator

No description provided.

@karmarunnerbot
Copy link
Member

Build karma 106 completed (commit b1a6f37d61 by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 105 failed (commit b1a6f37d61 by @devoto13)

@devoto13 devoto13 closed this Feb 29, 2020
@devoto13 devoto13 reopened this Feb 29, 2020
@karmarunnerbot
Copy link
Member

Build karma 107 completed (commit b6221897a9 by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 106 completed (commit b6221897a9 by @devoto13)

@AppVeyorBot
Copy link

Build karma 2505 completed (commit b6221897a9 by @devoto13)

Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks

lib/launcher.js Show resolved Hide resolved
lib/server.js Show resolved Hide resolved
@AppVeyorBot
Copy link

Build karma 2531 completed (commit a30841352f by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 133 completed (commit a30841352f by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 132 completed (commit a30841352f by @devoto13)

@AppVeyorBot
Copy link

Build karma 2532 completed (commit a064a329cb by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 133 completed (commit a064a329cb by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 134 completed (commit a064a329cb by @devoto13)

@devoto13 devoto13 closed this Mar 21, 2020
@devoto13 devoto13 reopened this Mar 21, 2020
@karmarunnerbot
Copy link
Member

Build karma 135 completed (commit c7b01f48f9 by @devoto13)

@AppVeyorBot
Copy link

Build karma 2533 completed (commit c7b01f48f9 by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 134 completed (commit c7b01f48f9 by @devoto13)

@devoto13
Copy link
Collaborator Author

Travis passed, but status on GitHub was not updated for some reason.

@devoto13 devoto13 closed this Mar 23, 2020
@devoto13 devoto13 reopened this Mar 23, 2020
@AppVeyorBot
Copy link

Build karma 2535 completed (commit ccb240da9b by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 137 completed (commit ccb240da9b by @devoto13)

@karmarunnerbot
Copy link
Member

Build karma 136 completed (commit ccb240da9b by @devoto13)

@devoto13 devoto13 requested a review from johnjbarton March 23, 2020 18:45
Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johnjbarton johnjbarton merged commit ffad7fa into karma-runner:master Mar 23, 2020
@devoto13 devoto13 deleted the feature-launcher branch April 7, 2020 15:12
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants