Skip to content

Commit

Permalink
webcompat#272 fixing a couple of jslint
Browse files Browse the repository at this point in the history
  • Loading branch information
karlcow committed Aug 6, 2015
1 parent e2fe3ab commit dd1b323
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/intern.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
define(['intern/lib/args'], function (args) {
'use strict';

var siteRoot = args.siteRoot ? args.siteRoot : 'http://localhost:5000';
var siteRoot = args.siteRoot || 'http://localhost:5000';

return {
// Configuration object for webcompat
Expand Down Expand Up @@ -37,7 +37,7 @@ define(['intern/lib/args'], function (args) {
functionalSuites: [ 'tests/functional' ],

// A regular expression matching URLs to files that should not be included in code coverage analysis
excludeInstrumentation: /./
excludeInstrumentation: /\./

This comment has been minimized.

Copy link
@miketaylr

miketaylr Aug 6, 2015

This should probably be /^.*/, rather than a literal dot. We don't use the code coverage stuff.

This comment has been minimized.

Copy link
@miketaylr

miketaylr Aug 6, 2015

(I'm not sure why jslint wants you to make this change, /./ was a valid regex).

This comment has been minimized.

Copy link
@karlcow

karlcow Aug 6, 2015

Author Owner

The /./ means any "one character". Was it what you wanted?
and if we do not use it should we comment it out? The documentation is not clear on whether it's mandatory to have it.
https://theintern.github.io/intern/#common-config

This comment has been minimized.

Copy link
@miketaylr

miketaylr Aug 6, 2015

We can change it to /^.*/, which will mean "anything". The one character regex will always return true for any file--which is the intent (and the functional equivalent for /./). It's to disable this report, which is useless for functional testing:

(it looks like if we upgrade to 3.0 we can just use true).

};

});

0 comments on commit dd1b323

Please sign in to comment.