Rewind fix #46
Merged
Rewind fix #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimthematrix
approved these changes
May 7, 2024
There was a problem hiding this comment.
approved with the same minor comments as in kaleido-io/go-ethereum#6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the snap root update changes made for geth to quorum. This update introduces two new geth configs
allowForceUpdate- That enables/disables the commit based snapRoot update checkcommitThreshold- The number of commits after which, the disk root should be updated. This value is set to 20 as default in eth-boot https://github.com/kaleido-io/photic-eth-boot/pull/112Corresponding Geth PR - kaleido-io/go-ethereum#6
Consortium with long lived environments for testing -
zzyxg7wl5u