Update dependency highlight.js to v10 [SECURITY] - autoclosed #82

renovate · 2020-11-28T15:04:17Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
highlight.js (source)	`9.15.6` -> `10.4.1`

GitHub Vulnerability Alerts

CVE-2020-26237

Impact

Affected versions of this package are vulnerable to Prototype Pollution. A malicious HTML code block can be crafted that will result in prototype pollution of the base object's prototype during highlighting. If you allow users to insert custom HTML code blocks into your page/app via parsing Markdown code blocks (or similar) and do not filter the language names the user can provide you may be vulnerable.

The pollution should just be harmless data but this can cause problems for applications not expecting these properties to exist and can result in strange behavior or application crashes, i.e. a potential DOS vector.

If your website or application does not render user provided data it should be unaffected.

Patches

Versions 9.18.2 and 10.1.2 and newer include fixes for this vulnerability. If you are using version 7 or 8 you are encouraged to upgrade to a newer release.

Workarounds

Patch your library

Manually patch your library to create null objects for both languages and aliases:

const HLJS = function(hljs) {
  // ...
  var languages = Object.create(null);
  var aliases = Object.create(null);

Filter out bad data from end users

Filter the language names that users are allowed to inject into your HTML to guarantee they are valid.

References

For more information

If you have any questions or comments about this advisory:

Please file an issue against highlight.js

GHSA-7wwv-vh3v-89cq

Impact: Potential ReDOS vulnerabilities (exponential and polynomial RegEx backtracking)

oswasp:

The Regular expression Denial of Service (ReDoS) is a Denial of Service attack, that exploits the fact that most Regular Expression implementations may reach extreme situations that cause them to work very slowly (exponentially related to input size). An attacker can then cause a program using a Regular Expression to enter these extreme situations and then hang for a very long time.

If are you are using Highlight.js to highlight user-provided data you are possibly vulnerable. On the client-side (in a browser or Electron environment) risks could include lengthy freezes or crashes... On the server-side infinite freezes could occur... effectively preventing users from accessing your app or service (ie, Denial of Service).

This is an issue with grammars shipped with the parser (and potentially 3rd party grammars also), not the parser itself. If you are using Highlight.js with any of the following grammars you are vulnerable. If you are using highlightAuto to detect the language (and have any of these grammars registered) you are vulnerable.

All versions prior to 10.4.1 are vulnerable, including version 9.18.5.

Grammars with exponential backtracking issues:

c-like (c, cpp, arduino)
handlebars (htmlbars)
gams
perl
jboss-cli
r
erlang-repl
powershell
routeros
livescript (10.4.0 and 9.18.5 included this fix)
javascript & typescript (10.4.0 included partial fixes)

And of course any aliases of those languages have the same issue. ie: hpp is no safer than cpp.

Grammars with polynomial backtracking issues:

kotlin
gcode
d
aspectj
moonscript
coffeescript/livescript
csharp
scilab
crystal
elixir
basic
ebnf
ruby
fortran/irpf90
livecodeserver
yaml
x86asm
dsconfig
markdown
ruleslanguage
xquery
sqf

And again: any aliases of those languages have the same issue. ie: ruby and rb share the same ruby issues.

Patches

Version 10.4.1 resolves these vulnerabilities. Please upgrade.

Workarounds / Mitigations

Discontinue use the affected grammars. (or perhaps use only those with poly vs exponential issues)
Attempt cherry-picking the grammar fixes into older versions...
Attempt using newer CDN versions of any affected languages. (ie using an older CDN version of the library with newer CDN grammars). Your mileage may vary.

References

https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS

For more information

If you have any questions or comments about this advisory:

Open an issue: https://github.com/highlightjs/highlight.js/issues
Email us at [email protected]

Release Notes

highlightjs/highlight.js

Update dependency highlight.js to v10 [SECURITY] - autoclosed #82

Update dependency highlight.js to v10 [SECURITY] - autoclosed #82

Conversation

renovate bot commented Nov 28, 2020 • edited Loading

GitHub Vulnerability Alerts

Impact

Patches

Workarounds

Patch your library

Filter out bad data from end users

References

For more information

Impact: Potential ReDOS vulnerabilities (exponential and polynomial RegEx backtracking)

Patches

Workarounds / Mitigations

References

For more information

Release Notes

Configuration

renovate bot commented Nov 28, 2020 •

edited

Loading