Setup base of the app with CRA-v2, CSS Modules and Sass #1
Conversation
README.md
Outdated
| - `yarn install` to install dependencies | ||
| - `yarn start` to run the server on `http://localhost:3000` | ||
|
|
||
| Demo app to be find [here](https://ka1130.github.io/TVloVe/). |
There was a problem hiding this comment.
I believe that this shouldn't be here yet
src/components/App/Header/index.js
Outdated
| @@ -0,0 +1,13 @@ | |||
| import React from 'react'; | |||
| import styles from './styles.module.scss'; | |||
There was a problem hiding this comment.
You can change the name of scss file to name of the component. It will produce you better className for debugging.
| @@ -0,0 +1,5 @@ | |||
| body { | |||
There was a problem hiding this comment.
Add come common resets here, please
There was a problem hiding this comment.
Sure, done. Hope I haven't added too much and it is fine not to add reset in a separate file in this case?
There was a problem hiding this comment.
It's enough to have it in this file. What about links text-decoration?
ka1130
force-pushed
the
cra-css-modules-sass
branch
from
0b8e192 to
1e4ae30
Compare
|
Thanks, @yakato ! The trick with changing the naming convention of the style files is awesome, it's a shame I haven't used it before. Yes, I have copy-pasted the contents of |
|
Thanks for improvements. Perfect basic setup 👍 |
|
Oh, right, text-decoration should be reset too, thanks! :) Cool, I will add this and merge then. :) |
This PR sets up the base of the application with CRA-v2 that has CSS Modules and Sass already integrated. Thus, the app has not been yet ejected.
The default view has been changed to a sample header.
To keep the code clean, VSCode
prettierplugin has been added with a basic configuration.