feat: support extraDeploy field in helm chart

[fengxsong]

This PR made the following changes:

1. Remove duplicate environment variable METRICS_EXPORTER_SECRET_NAME and correct the METRICS_EXPORTER_PORT environment variable.

2. Support adding additional deployment objects in the Helm chart, such as SriovNetworkNodePolicy and SriovNetwork, along with the release.

[github-actions]

Thanks for your PR,
To run vendors CIs use one of:

• /test-all: To run all tests for all vendors.
• /test-e2e-all: To run all E2E tests for all vendors.
• /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

• /skip-all: To skip all tests for all vendors.
• /skip-e2e-all: To skip all E2E tests for all vendors.
• /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
  Best regards.

[zeeke]

Hi @fengxsong, thanks for filing this PR.
Quoting the value of METRICS_EXPORTER_PORT has already been addressed here:

• e2e: Use helm to deploy on k8s cluster #704

Do you mind removing it so we can discuss the extraDeploy proposal? What's the use case it would solve?

[adrianchiris]

im not sure we should support deploying arbitrary "things" as part of the chart.

my take is that the chart should deploy the minimal set of components that are required for sriov network operator to work.
other CRs should be deployed as a post install/update step.

[github-actions]

Thanks for your PR,
To run vendors CIs use one of:

• /test-all: To run all tests for all vendors.
• /test-e2e-all: To run all E2E tests for all vendors.
• /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

• /skip-all: To skip all tests for all vendors.
• /skip-e2e-all: To skip all E2E tests for all vendors.
• /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
  Best regards.

[fengxsong]

@zeeke I have reverted this part of the modification back.

my take is that the chart should deploy the minimal set of components that are required for sriov network operator to work.

@adrianchiris yes, I'm agree with that, keeping deployments as simple as possible is a good point, but sometimes it might be better to provide simple functionality extensions.

In the scenario where we manage cluster deployments using GitOps, I prefer a single deployment that includes everything needed rather than applying additional configurations after deployment.

---

since charts in bitnami/charts has already supported this feature, I think this is a nice to have feature :)

[coveralls]

Pull Request Test Coverage Report for Build 9695800137

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 40.375%

---

Totals
Change from base Build 9691456203:	0.0%
Covered Lines:	5455
Relevant Lines:	13511

---

💛 - Coveralls

[adrianchiris]

Hi @fengxsong we discussed this in today's community meeting. we are OK with this change. please add a disclaimer in helm chart README that whatever is deployed via this value is the user's responsibility.

[github-actions]

Thanks for your PR,
To run vendors CIs use one of:

• /test-all: To run all tests for all vendors.
• /test-e2e-all: To run all E2E tests for all vendors.
• /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

• /skip-all: To skip all tests for all vendors.
• /skip-e2e-all: To skip all E2E tests for all vendors.
• /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
  Best regards.

[coveralls]

Pull Request Test Coverage Report for Build 9770204124

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 323 unchanged lines in 6 files lost coverage.
• Overall coverage increased (+0.2%) to 40.617%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/webhook/validate.go	27	64.05%
test/util/util.go	37	42.68%
pkg/apply/merge.go	40	76.02%
controllers/sriovoperatorconfig_controller.go	64	63.76%
controllers/sriovnetworknodepolicy_controller.go	77	12.13%
api/v1/helper.go	78	73.91%

Totals
Change from base Build 9691456203:	0.2%
Covered Lines:	5515
Relevant Lines:	13578

---

💛 - Coveralls

[SchSeba]

LGTM