Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regenerate API pkg with controller-gen 0.14.0 and go 1.22 #725

Merged

Conversation

ykulazhenkov
Copy link
Collaborator

when make generate is called with controller-gen 0.14.0 (specified in the Makefile) and go 1.22 the zz_generated.deepcopy.go will have no // +build !ignore_autogenerated line.

Copy link

Thanks for your PR,
To run vendors CIs use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Jun 26, 2024

Pull Request Test Coverage Report for Build 9675806741

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 100 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.007%) to 40.382%

Files with Coverage Reduction New Missed Lines %
api/v1/zz_generated.deepcopy.go 100 38.08%
Totals Coverage Status
Change from base Build 9667839529: 0.007%
Covered Lines: 5456
Relevant Lines: 13511

💛 - Coveralls

Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianchiris adrianchiris merged commit efa6384 into k8snetworkplumbingwg:master Jun 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants