Configure IB VFs' GUIDs using a statically provided GUID pool #659

almaslennikov · 2024-03-18T07:48:19Z

Dependent on the design doc PR: #653

TBD

github-actions · 2024-03-18T07:48:30Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-03-18T09:30:07Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-03-18T09:41:15Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-03-18T09:51:38Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

ykulazhenkov

Thx for the PR @almaslennikov! I added few comments

pkg/consts/constants.go

pkg/utils/guid.go

pkg/utils/utils.go

pkg/utils/guid.go

pkg/host/types/interfaces.go

pkg/host/internal/sriov/sriov.go

github-actions · 2024-03-25T07:50:43Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-03-26T07:52:32Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-03-26T07:58:41Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

ykulazhenkov

partial review, I need to have another look at the PR

pkg/host/types/interfaces.go

ykulazhenkov · 2024-03-26T08:31:09Z

pkg/host/internal/sriov/sriov.go

@@ -145,14 +149,14 @@ func (s *sriov) GetVfInfo(pciAddr string, devices []*ghw.PCIDevice) sriovnetwork
 	return vf
 }

-func (s *sriov) SetVfGUID(vfAddr string, pfLink netlink.Link) error {
+func (s *sriov) SetVfGUID(vfAddr string, guid net.HardwareAddr, pfLink netlink.Link) error {


Is this method still used anywhere?

The method is still there. Do we need it?

this is still here :) i dont think its being used

@almaslennikov can you address this one ? :)

pkg/consts/constants.go

pkg/host/internal/infiniband/ib_guid_config_test.go

github-actions · 2024-04-02T10:41:46Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-04-02T10:43:04Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-04-02T11:30:49Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-04-09T07:52:09Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-04-09T08:56:00Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

pkg/host/types/interfaces.go

pkg/host/internal/infiniband/mock/mock_infiniband.go

pkg/host/internal/kernel/mock/mock_kernel.go

ykulazhenkov · 2024-04-11T13:05:10Z

pkg/host/internal/sriov/sriov.go

@@ -145,14 +149,14 @@ func (s *sriov) GetVfInfo(pciAddr string, devices []*ghw.PCIDevice) sriovnetwork
 	return vf
 }

-func (s *sriov) SetVfGUID(vfAddr string, pfLink netlink.Link) error {
+func (s *sriov) SetVfGUID(vfAddr string, guid net.HardwareAddr, pfLink netlink.Link) error {


The method is still there. Do we need it?

pkg/host/internal/network/network.go

pkg/utils/guid.go

pkg/host/internal/infiniband/infiniband.go

ykulazhenkov · 2024-04-12T09:24:06Z

pkg/host/internal/infiniband/infiniband.go

+}
+
+func (i *infiniband) ConfigureVfGUID(vfAddr string, pfAddr string, vfID int, pfLink netlink.Link) error {
+	guid := utils.GenerateRandomGUID()


Maybe we can move GenerateRandomGUID() function to the this package (infiniband)?

can we move this to infiniband package ?

pkg/host/internal/infiniband/ib_guid_pool.go

pkg/host/internal/infiniband/ib_guid_config.go

pkg/host/internal/infiniband/ib_guid_config_test.go

github-actions · 2024-04-12T12:27:10Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

ykulazhenkov · 2024-04-12T14:10:48Z

It looks like there is some problem with branch base. The branch contains commits which it shouldn't have.

github-actions · 2024-05-27T06:00:27Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

adrianchiris

once remaining comments addressed im LGTM.

Thx for the work @almaslennikov

pkg/host/manager.go

adrianchiris · 2024-06-25T08:20:13Z

pkg/host/internal/sriov/sriov.go

@@ -145,14 +149,14 @@ func (s *sriov) GetVfInfo(pciAddr string, devices []*ghw.PCIDevice) sriovnetwork
 	return vf
 }

-func (s *sriov) SetVfGUID(vfAddr string, pfLink netlink.Link) error {
+func (s *sriov) SetVfGUID(vfAddr string, guid net.HardwareAddr, pfLink netlink.Link) error {


@almaslennikov can you address this one ? :)

pkg/host/internal/infiniband/guid_test.go

pkg/host/internal/infiniband/infiniband_test.go

pkg/host/internal/infiniband/ib_guid_pool.go

pkg/host/internal/infiniband/ib_guid_pool_test.go

pkg/host/internal/infiniband/ib_guid_config.go

adrianchiris · 2024-06-25T10:40:19Z

also we should have some user documentation for this feature under doc

github-actions · 2024-06-27T17:51:22Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-06-27T17:53:19Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-06-27T18:00:34Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-06-27T18:03:15Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

github-actions · 2024-06-27T18:14:30Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

adrianchiris

getting close :)

doc/ib-vf-guid-configuration.md

github-actions · 2024-07-04T09:49:33Z

Thanks for your PR,
To run vendors CIs use one of:

/test-all: To run all tests for all vendors.
/test-e2e-all: To run all E2E tests for all vendors.
/test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs use one of:

/skip-all: To skip all tests for all vendors.
/skip-e2e-all: To skip all E2E tests for all vendors.
/skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
Best regards.

adrianchiris

LGTM ! thx @almaslennikov 🎉

adrianchiris · 2024-07-11T15:22:44Z

@SchSeba PTAL :) i believe we can merge this one.

SchSeba

Really nice work just two small comments and we can merge this one

doc/ib-vf-guid-static-configuration.md.md

pkg/host/internal/infiniband/infiniband.go

adrianchiris · 2024-07-18T11:38:41Z

@almaslennikov could you rebase and address comments, i think thats the last stretch b4 merging this one :)

Signed-off-by: amaslennikov <[email protected]>

switch sriov module to use the new interface Signed-off-by: amaslennikov <[email protected]>

new package incapsulates the guid config file validation, guid pool implementation and host manipulations to set IB VF GUIDs

Signed-off-by: amaslennikov <[email protected]>

SchSeba

LGTM

almaslennikov force-pushed the guid-config branch from 19e70f6 to 18d5e84 Compare March 18, 2024 09:29

almaslennikov force-pushed the guid-config branch from 18d5e84 to f6ba5ef Compare March 18, 2024 09:41

almaslennikov force-pushed the guid-config branch from f6ba5ef to 7cad4f9 Compare March 18, 2024 09:51

ykulazhenkov reviewed Mar 20, 2024

View reviewed changes

almaslennikov force-pushed the guid-config branch from 7cad4f9 to bcbd96d Compare March 25, 2024 07:50

almaslennikov force-pushed the guid-config branch from bcbd96d to 7492ffd Compare March 26, 2024 07:52

almaslennikov force-pushed the guid-config branch from 7492ffd to 9cba435 Compare March 26, 2024 07:58

ykulazhenkov reviewed Mar 26, 2024

View reviewed changes

almaslennikov force-pushed the guid-config branch from 9cba435 to 236e10b Compare April 2, 2024 10:41

almaslennikov force-pushed the guid-config branch from 236e10b to a68bf0d Compare April 2, 2024 10:42

almaslennikov force-pushed the guid-config branch from a68bf0d to 3823ee6 Compare April 2, 2024 11:30

almaslennikov force-pushed the guid-config branch from 3823ee6 to 10dc541 Compare April 9, 2024 07:51

almaslennikov force-pushed the guid-config branch from 10dc541 to a553099 Compare April 9, 2024 08:55

ykulazhenkov reviewed Apr 11, 2024

View reviewed changes

ykulazhenkov reviewed Apr 12, 2024

View reviewed changes

almaslennikov force-pushed the guid-config branch from a553099 to 7ba5e31 Compare April 12, 2024 12:26

almaslennikov force-pushed the guid-config branch from 7332d30 to ae28217 Compare May 27, 2024 06:00

adrianchiris reviewed Jun 25, 2024

View reviewed changes

almaslennikov force-pushed the guid-config branch from ae28217 to ca219d3 Compare June 27, 2024 17:51

almaslennikov force-pushed the guid-config branch from ca219d3 to 418c6bc Compare June 27, 2024 17:53

almaslennikov force-pushed the guid-config branch from 418c6bc to 1e85f07 Compare June 27, 2024 18:00

almaslennikov force-pushed the guid-config branch from 1e85f07 to 68e7b6b Compare June 27, 2024 18:03

almaslennikov force-pushed the guid-config branch from 68e7b6b to 40f8039 Compare June 27, 2024 18:14

adrianchiris reviewed Jul 2, 2024

View reviewed changes

almaslennikov force-pushed the guid-config branch from 40f8039 to 0978395 Compare July 4, 2024 09:49

adrianchiris approved these changes Jul 8, 2024

View reviewed changes

SchSeba reviewed Jul 17, 2024

View reviewed changes

doc/ib-vf-guid-static-configuration.md.md Outdated Show resolved Hide resolved

pkg/host/internal/infiniband/infiniband.go Show resolved Hide resolved

almaslennikov force-pushed the guid-config branch from 0978395 to a718c3d Compare July 22, 2024 07:05

almaslennikov added 5 commits July 23, 2024 15:21

Add LinkList() method to netlink library wrapper

b51ba3b

Signed-off-by: amaslennikov <[email protected]>

Move IB VF configuration to the IB interface

7116dc0

switch sriov module to use the new interface Signed-off-by: amaslennikov <[email protected]>

Add implementation of Infiniband interface

0022c10

new package incapsulates the guid config file validation, guid pool implementation and host manipulations to set IB VF GUIDs

Create instance of IB interface in the host object

2886ca6

Signed-off-by: amaslennikov <[email protected]>

Add doc article

f199eb9

Signed-off-by: amaslennikov <[email protected]>

almaslennikov force-pushed the guid-config branch from a718c3d to f199eb9 Compare July 23, 2024 12:22

SchSeba approved these changes Jul 23, 2024

View reviewed changes

SchSeba merged commit 73fbca2 into k8snetworkplumbingwg:master Jul 23, 2024
13 checks passed

Configure IB VFs' GUIDs using a statically provided GUID pool #659

Configure IB VFs' GUIDs using a statically provided GUID pool #659

Conversation

almaslennikov commented Mar 18, 2024

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 18, 2024

github-actions bot commented Mar 18, 2024

ykulazhenkov left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 25, 2024

github-actions bot commented Mar 26, 2024

github-actions bot commented Mar 26, 2024

ykulazhenkov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Apr 2, 2024

github-actions bot commented Apr 2, 2024

github-actions bot commented Apr 2, 2024

github-actions bot commented Apr 9, 2024

github-actions bot commented Apr 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Apr 12, 2024

ykulazhenkov commented Apr 12, 2024

github-actions bot commented May 27, 2024

adrianchiris left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adrianchiris commented Jun 25, 2024

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

adrianchiris left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 4, 2024

adrianchiris left a comment

Choose a reason for hiding this comment

adrianchiris commented Jul 11, 2024

SchSeba left a comment

Choose a reason for hiding this comment

adrianchiris commented Jul 18, 2024

SchSeba left a comment

Choose a reason for hiding this comment