Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetNetIndex function to utils #569

Closed

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Jun 26, 2024

No description provided.

@coveralls
Copy link
Collaborator

coveralls commented Jun 26, 2024

Pull Request Test Coverage Report for Build 9678644165

Details

  • 19 of 23 (82.61%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 75.247%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/utils/utils.go 19 23 82.61%
Totals Coverage Status
Change from base Build 9579008714: 0.06%
Covered Lines: 2134
Relevant Lines: 2836

💛 - Coveralls

Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SchSeba
Copy link
Collaborator Author

SchSeba commented Jun 26, 2024

@adrianchiris @e0ne can you please review this one?

@adrianchiris
Copy link
Contributor

@SchSeba we ended up not needing this one right ?

@SchSeba
Copy link
Collaborator Author

SchSeba commented Jul 3, 2024

yep we didn't use this one at the end for the sriov operator so I will close this PR.
we can re-open if it will be needed in the future

@SchSeba SchSeba closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants