Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EndPort to v1beta1 #24

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Add EndPort to v1beta1 #24

merged 1 commit into from
Dec 11, 2024

Conversation

zeeke
Copy link
Member

@zeeke zeeke commented Oct 4, 2024 •
edited
Loading

Add EndPort field to scheme.yml and MultiNetworkPolicyPort Go type.

Fix #23

@zeeke
Copy link
Member Author

zeeke commented Oct 23, 2024

@s1061123 @pliurh @dougbtv can you please take a look?

I think it shouldn't break any scenario, even if the deployed CRD does not have the endPort field

@zeeke
Add EndPort to v1beta1
d9c1d27 
Add `EndPort` field to `scheme.yml` and `MultiNetworkPolicyPort` Go type.

Signed-off-by: Andrea Panattoni <[email protected]>
@zeeke zeeke changed the title Align v1beta1 Go files Add EndPort to v1beta1 Nov 27, 2024
@zeeke zeeke requested a review from dougbtv December 11, 2024 11:19
dougbtv
dougbtv approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@dougbtv dougbtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you!

@dougbtv dougbtv merged commit a6d2c54 into k8snetworkplumbingwg:master Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbtv dougbtv dougbtv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When will v1beta2 be fixed?
2 participants
@zeeke @dougbtv