Fix padding_idx #942
Merged
Fix padding_idx #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csukuangfj
approved these changes
Mar 10, 2023
|
Here is the huggingface link to the new model: https://huggingface.co/marcoyang/icefall-asr-librispeech-pruned-transducer-stateless7-2023-03-10 |
|
Should this be fixed also in the new zipformer model: https://github.com/k2-fsa/icefall/blob/0ad037d0762ecdf7ebeb40d7a196cc6280e8a535/egs/librispeech/ASR/zipformer/decoder.py#LL61C20-L61C20? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone mentioned in #923 that the non-streaming Transducer models tend to emit the first non-blank symbol at the very beginning. This PR alleviates this issue by removing the
padding_idxin the decoder. Here are some results ofpruned_transducer_stateless7on LibriSpeech:padding_idx=0padding_idx=NoneIf someone needs this model, I can upload it to huggingface.