Validate k0s config before installing into k0s config path #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kimmo Lehto <[email protected]>
kke
force-pushed
the
prevalidate-k0s-config
branch
from
f017b58 to
2d6d4d3
Compare
Signed-off-by: Kimmo Lehto <[email protected]>
|
Seems like |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #562
Before this PR k0sctl wrote the config directly to
/etc/k0s/k0s.yaml(orh.Configurer.K0sConfigPath())If the configuration was invalid, the broken config would have been left in as the current k0s config and restarting the server would make it fail to wake up again.
This PR first writes the config into a temp file and validates it, if the validation passes, only then it will be used to replace the effective configuration.