Replace unsafe sprintf in examples

justinhj · Apr 1, 2023 · 26b33ed · 26b33ed
1 parent 3de77ee
commit 26b33ed
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/cpp/8puzzle.cpp b/cpp/8puzzle.cpp
@@ -337,8 +337,9 @@ bool PuzzleState::IsSameState( PuzzleState &rhs )
 
 void PuzzleState::PrintNodeInfo()
 {
-	char str[100];
-	sprintf( str, "%c %c %c\n%c %c %c\n%c %c %c\n", 
+  const int strSize = 100;
+	char str[strSize];
+	snprintf( str, strSize, "%c %c %c\n%c %c %c\n%c %c %c\n", 
 			tiles[0] + '0',
 			tiles[1] + '0',
 			tiles[2] + '0',

diff --git a/cpp/tests.cpp b/cpp/tests.cpp
@@ -97,8 +97,9 @@ bool MapSearchNode::IsSameState( MapSearchNode &rhs )
 
 void MapSearchNode::PrintNodeInfo()
 {
-	char str[100];
-	sprintf( str, "Node position : (%d,%d)\n", x,y );
+  const int strSize = 100;
+	char str[strSize];
+	snprintf( str, strSize, "Node position : (%d,%d)\n", x,y );
 
 	cout << str;
 }