Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a github link to the documentation #82

Merged
merged 2 commits into from
Jan 9, 2023
Merged

add a github link to the documentation #82

merged 2 commits into from
Jan 9, 2023

Conversation

12rambau
Copy link
Contributor

@12rambau 12rambau commented Jan 9, 2023

Fix #80

everything is in the title ;-)

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@martinRenou
Copy link
Member

@12rambau I don't see the Github link appearing in the rtd build: https://jupyterlite-sphinx--82.org.readthedocs.build/en/82 Where should it appear?

@12rambau
Copy link
Contributor Author

12rambau commented Jan 9, 2023

oups I'm not seeing it as well that's weird it should be after the light/dark button. Let me check the parameter again and do a local build before my next commit

@12rambau
Copy link
Contributor Author

12rambau commented Jan 9, 2023

@martinRenou I was one typo away from setting it correctly. It worked on my local build but I can't see the RDT test anymore (maybe because you already approved the change).

@martinRenou
Copy link
Member

Thanks! Triggering a build

@martinRenou martinRenou closed this Jan 9, 2023
@martinRenou martinRenou reopened this Jan 9, 2023
@martinRenou
Copy link
Member

Thanks!

@martinRenou martinRenou merged commit f8c7f0e into jupyterlite:main Jan 9, 2023
@12rambau 12rambau deleted the github_link branch January 9, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No link to GitHub from the docs
2 participants