Run jupyter lite with subprocess.run to not suppress stdout #55
Conversation
|
With this, I bet we'll start seeing the errors in building the current jupyterlite-sphinx docs. |
Yep, now we see the error at the bottom of https://readthedocs.org/api/v2/build/17204236.txt Since jupyter lite still returned a zero error code indicating success, though, the docs build did not fail. |
There was a problem hiding this comment.
This is great thanks! It's been super annoying to debug jupyterlite-sphinx builds without this. Let's see if #56 fixes the lite build.
It looks like there is a black check failure on the Python code
|
Can you please rebase your PR? We should now not see error logs with #56 in |
check_output redirects stdout, so we don't see it when we do sphinx-build. We instead switch to using subprocess.run so that we can see the stdout output. Suppressing stdout was causing errors in jupyter lite to not be displayed, which was very confusing. A separate issue is that jupyter lite is not returning a nonzero exit code when there is an error. But that is a problem to solve in jupyter lite. Once it is solved, having the check=True means that the sphinx build will also raise an error.
Done! |
|
New error: |
|
Yes, this might be due to the new jupyterlite release that just came out. I'll have a look. |
|
Maybe installing Line 12 in e8a21e9 Since |
|
Yay, tests pass and docs look great! Back to adding this to ipywidgets, once this is released... |
|
Great thanks Jason! |
|
@jasongrout 0.4.8 is released :) |
check_output redirects stdout, so we don't see it when we do sphinx-build. We instead switch to using subprocess.run so that we can see the stdout output.
Suppressing stdout was causing errors in jupyter lite to not be displayed, which was very confusing.
A separate issue is that jupyter lite is not returning a nonzero exit code when there is an error. But that is a problem to solve in jupyter lite. Once it is solved, having the check=True means that the sphinx build will also raise an error.