Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring restricted access to the /learn index directory #887

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Jul 10, 2024

Fixes #886

  • adds a test which should fail
  • fixes the issue by specifying the mode and using a more advanced ensure_dir_exists logic

@krassowski krassowski added the bug Something isn't working label Jul 10, 2024
@krassowski krassowski force-pushed the set-mode-on-index-dir branch from 4c4825b to d01bac1 Compare July 10, 2024 13:25
@krassowski krassowski marked this pull request as ready for review July 10, 2024 13:59
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krassowski Thank you!

@dlqqq dlqqq merged commit 6b21c03 into jupyterlab:main Jul 10, 2024
8 of 9 checks passed
Marchlak pushed a commit to Marchlak/jupyter-ai that referenced this pull request Oct 28, 2024
…b#887)

* Add a test ensuring correct mode of index dir

* Ensure dir exists with correct mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index folder created in data-dir should explicitly set permission modes
2 participants