Catch embedding model validation errors on extension init #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3coins
reviewed
Apr 17, 2024
3coins
approved these changes
Apr 17, 2024
|
@meeseeksdev please backport to 1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyter-ai
that referenced
this pull request
Apr 22, 2024
…n extension init
dlqqq
added a commit
that referenced
this pull request
Apr 22, 2024
…n init (#740) Co-authored-by: david qiu <[email protected]>
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
…#735) * catch embedding model validation errors on extension init * pre-commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The embedding model sometimes raises an exception when instantiated, which causes the server extension to fail initializing and show the "There seems to be a problem with the chat backend" error to the user.
This PR catches the raised exception to allow for the server extension to finish initializing even if the embedding model raises an exception.