-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move magics to jupyter-ai-magics
package
#48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified locally using Node 18.13.0 — thanks @dlqqq for your help!
Yes, for some reason the labextension build fails for the latest Node 18.15.0. Full log:
|
Uploaded |
Check release workflow is passing, CI is green. Failing workflow is identical to the passing one, except that it wasn't re-run by closing & re-opening the PR. Merging. 🎉 |
* move magics to new jupyter-ai-magics project * add dev-uninstall script * add jupyter-ai-magics to releaser python packages list * remove scripts/install.sh * allow magics to be loaded from jupyter-ai * add importlib_metadata as dependency to jupyter_ai_magics
* move magics to new jupyter-ai-magics project * add dev-uninstall script * add jupyter-ai-magics to releaser python packages list * remove scripts/install.sh * allow magics to be loaded from jupyter-ai * add importlib_metadata as dependency to jupyter_ai_magics
Description
Fixes #47
Other improvements:
jlpm setup:dev
after creating a new Hatch environmentjlpm dev-install
: install all Jupyter AI packages, replacesscripts/install.sh
jlpm dev-uninstall
: uninstall all Jupyter AI packages--scope
argument to Lerna, so this can be used to selectively test packages in your Hatch environmentVerification
This process uses Jupyter Releaser to build wheels and install them locally. This offers the highest confidence that the packages will behave as expected when released onto PyPi.
Build the wheels (uses same process that Jupyter Releaser uses):
Verify that the wheels are built in
.jupyter_releaser_checkout/dist
:Then, install the wheels locally and perform the same tests outlined above:
Notes
The CI
check-release
step will fail becausejupyter_ai_magics
isn't published to PyPi yet. We need to verify it fails for the same reason: