Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set packageManager #79

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Set packageManager #79

merged 1 commit into from
Jun 18, 2024

Conversation

fcollonval
Copy link
Member

This is set to avoid issue with tools like dependabot that may run a different version of yarn resulting in a different yarn.lock version.

I could improve this using copier-templates-extensions to run jlpm --version. But that will add a dependency.

@fcollonval fcollonval added the enhancement New feature or request label Jun 18, 2024
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krassowski krassowski merged commit c68f45a into main Jun 18, 2024
24 checks passed
@krassowski krassowski deleted the fcollonval-patch-1 branch June 18, 2024 10:49
@fcollonval
Copy link
Member Author

fcollonval commented Jun 18, 2024

I'm having second thought about this one as yarn will complain if corepack is not enabled by the user. And it is not by default as this is officially still an experimental feature of NodeJS.

Should we keep that as a trick for fixing our CI instead of pushing it to everybody?

cc @jtpio @krassowski

@krassowski
Copy link
Member

krassowski commented Jun 19, 2024

The complaint is just a warning, right? Or does it error out?

@bollwyvl
Copy link

bollwyvl commented Jun 19, 2024 via email

@fcollonval
Copy link
Member Author

The complaint is just a warning, right? Or does it error out?

It unfortunately errors out 😔 as can be seen there
https://github.com/jupyterlab-contrib/jupyterlab-variableInspector/actions/runs/9548637850/job/26316282441

@fcollonval
Copy link
Member Author

I have found corepack to be... not a great user experience, under any
condition.

I agree and I'm really sad that yarn went all-in that experimental feat' that is far from stable between nodeJS versions.

@fcollonval
Copy link
Member Author

So I'm gonna revert this one

fcollonval added a commit that referenced this pull request Jun 20, 2024
fcollonval added a commit that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants