Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt sp-repo-review #7039

Merged
merged 8 commits into from
Sep 12, 2023
Merged

Adopt sp-repo-review #7039

merged 8 commits into from
Sep 12, 2023

Conversation

blink1073
Copy link
Contributor

Adopt pypi.org/project/sp-repo-review, which has a standard set of checks for packages in the scientific python ecosystem, as seen in learn.scientific-python.org/development.

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch blink1073/notebook/sp-repo-review

{% endblock %}
</head>
<body data-notebook="edit">
{# Copy so we do not modify the page_config with updates. #} {% set
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we might want to keep the previous line breaks here for readability.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@blink1073 blink1073 requested a review from jtpio September 12, 2023 01:38
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 14fce8c into jupyter:main Sep 12, 2023
29 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants