Add the JupyterLab resources plugin #6968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jtpio
commented
Jul 17, 2023
| @@ -34,7 +34,7 @@ const RESOURCES = [ | |||
| * The command IDs used by the help plugin. | |||
| */ | |||
| namespace CommandIDs { | |||
| export const open = 'help:open'; | |||
| export const open = 'help:open-tab'; | |||
There was a problem hiding this comment.
This is temporarily required since the upstream plugin already defines the help:open command, and would fail to activate if it already exists.
There was a problem hiding this comment.
But it prevents opening some links in new browser tabs since the JupyterLab tries to add the page in the main area with IFrames.
There was a problem hiding this comment.
Opened jupyterlab/jupyterlab#14837
This was referenced Jul 17, 2023
jtpio
force-pushed
the
resources-links
branch
from
218b3f0 to
90568e4
Compare
jtpio
force-pushed
the
resources-links
branch
from
90568e4 to
a58bdd8
Compare
jtpio
force-pushed
the
resources-links
branch
from
a58bdd8 to
dceb2e9
Compare
|
bot please update playwright snapshots |
jtpio
force-pushed
the
resources-links
branch
from
37445be to
9090e1e
Compare
|
CI back to green with #7170. This should now be good to go. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6963
This also brings additional resource links from JupyterLab that we might want to hide from the menu.