-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"not implemented" message with jupyter notebook under python-3.8.0a4 (due to switch to "proactor" loop on windows) #4613
Comments
Life on the edge - this appears to be a side-affect of Python 3.8 on Windows: tornadoweb/tornado#2608. |
yes, Python masters do alpha of python-3.8.0.a4, so I suppose it is to use it for some blood-bath testing, like a good episode of GOT. |
and so apparently, Tornado has zero intention to use the "Proactor" event loop. Maybe Jupyter Notebook has to implement a change ? or ask Python asyncio masters to revert to previous default ? |
Apparently progress is at tornadoweb/tornado#2656 (comment) |
and there may be also further impact on "async exec", if it lands in Python-3.8.0b1 https://bugs.python.org/issue34616 |
so @jasongrout , as Tornado team doesn't whish to enforce this, it seems the Jupyter applications have to replace in all its packages that can launch first the asyncio loop :
per
|
@stonebig What if users want to configure another event loop policy, as mentioned here: #4184 (comment) How about calling |
@rolweber my "hard way" fix is for sure lacking in subtlety. it's alpha4 answer to alpha4 problem. |
ah, maybe hope from another direction https://bugs.python.org/issue29883 |
I find it's apparently a limitation of 0mq ... https://python-tulip.narkive.com/x36hFXG2/proactoreventloop-and-add-reader-add-writer |
latest news : https://bugs.python.org/issue37373 |
Apparently there is an undocumentd solution python-trio/trio#52, and Nathaniel looks enthousiastic python-trio/trio#52 (comment) |
It seems that the problem is still there for the final 3.8.0. Is there a timeline for a fix? Should there at least be a warning on the Jupyter website to stop Windows users from upgrading their Python distribution. |
(My English is poor). If some people fix that, what will I do? upgrade python or upgrade jupyter? |
Upgrade jupyter or any affiliated package |
@jackexu thank you. |
Still not fixed... |
Fixed now - upgrade jupyter-core to 4.6.1 |
No, it's not. Look: Installing:
Running Notebook:
|
It is working on my Macbook but not on Windows... |
In windows 10 getting the same error Traceback (most recent call last): |
workaround from https://stackoverflow.com/a/58430041: add this to import sys
if sys.platform == 'win32':
asyncio.set_event_loop_policy(asyncio.WindowsSelectorEventLoopPolicy()) |
that worked for me!! thank you :-) |
It's working - Thank you! |
Works like a charm ! |
Can I find a timeline for that somewhere? If it's just a short amount of time I'll wait before trying to hack my local install. |
Echoing: is 6.0.3 coming soon? I have some 3.8 only code I really want to start using in notebooks. And the workaround gets removed when I install jupyter to my virtual environment. |
FYI -- this problem remains: Windows 10, Python 3.8.0 pip install jupyterlab jupyter lab |
It really worked for windows10 and pytho 3.8 import asyncio if sys.platform == 'win32': |
I also still have this issue on Windows 10 with Python 3.8.1 and Tornado 6.0.3
|
Still have the same issue on Windows 10 with Python 3.8.1 and Pip 19.3.1
|
Works perfectly for me on Python 3.8.1 |
The problem that I have found with the workaround is when I create a new virtual environment it pulls down the non patched code and becomes broken again. Would be nice if jupyter notebook 6.0.3 would drop soon so this problem would just go away. Since the issue becomes recreated every time I make a new venv I've just had to not use 3.8 for the time being, which is kind of a bummer. Thanks to all who are working on this project I really appreciate it. |
I think we can expect a Notebook 6.0.3 drop in the next day or two. I believe it was delayed by a conda-forge issue with a required project. |
It seems the notebook 6.0.3 dropped last night. Unfortunately, I am getting the NotImplementedError when attempting to launch jupyter qtconsole. If I try to update qtconsole from conda-forge, I get the message "All requested packages already installed" |
@thomco - sorry for the frustration. qtconsole is maintained in a separate repo (https://github.com/jupyter/qtconsole) and will need a patch similar to those made for notebook (#5047) and ipykernel (ipython/ipykernel#456). Looks like the following issue may be tracking it: jupyter/qtconsole#400 |
Patch for "Not Implemented Error" for IDA 7.5 with Python 3 (3.8.2). Code from jupyter/notebook#4613
I have this strange message with Tornado-5.1.1 and Jupyter Notebook
Does anyone as a clue of the problem ? is it a Tornado, a Notebook, a Python-3.8.0a4 bug (or feature) ?
The text was updated successfully, but these errors were encountered: