Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update developer installation instructions #989

Merged
merged 2 commits into from
Jul 18, 2018

Conversation

cdvv7788
Copy link

@cdvv7788 cdvv7788 commented Jul 4, 2018

Make changes as required at #862

@cdvv7788
Copy link
Author

cdvv7788 commented Jul 4, 2018

@jhamrick Is this what you had in mind for #862 ?

@jhamrick
Copy link
Member

jhamrick commented Jul 7, 2018

Thanks!

I think it would be a bit clearer for new developers that all three commands should be run if the they are one right after another with no linebreaks/comments, e.g.:

jupyter nbextension install --symlink --sys-prefix --py nbgrader
jupyter nbextension enable --sys-prefix --py nbgrader
jupyter serverextension enable --sys-prefix --py nbgrader

The other documentation (e.g. about what the symlink is doing) could go before or after (but ideally not as comments in the code block itself).

Copy link
Member

@jhamrick jhamrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(See my comment above)

@jhamrick jhamrick added this to the 0.6.0 milestone Jul 7, 2018
@cdvv7788
Copy link
Author

@jhamrick Better?

@jhamrick
Copy link
Member

Looks great now, thanks!

@jhamrick jhamrick merged commit 283ef9e into jupyter:master Jul 18, 2018
@cdvv7788 cdvv7788 deleted the nbgrader-862 branch July 18, 2018 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants