-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from PhamtomJS to Firefox #936
Conversation
a84b5de
to
e4477ca
Compare
So this has turned out to be way more annoying of a change than I anticipated. In particular, it seems the most annoying thing is that Firefox appears to leak memory as more tests are run. For There are also still some tests that are flaky, like |
Fixes #935
Note that unfortunately, the Firefox webdriver does not support capturing logs from javascript. This is annoying, but not a dealbreaker.
In making this change I uncovered a bunch of race conditions in the javascript tests, which is good I guess!