Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from PhamtomJS to Firefox #936

Merged
merged 10 commits into from
May 8, 2018
Merged

Conversation

jhamrick
Copy link
Member

Fixes #935

Note that unfortunately, the Firefox webdriver does not support capturing logs from javascript. This is annoying, but not a dealbreaker.

In making this change I uncovered a bunch of race conditions in the javascript tests, which is good I guess!

@jhamrick jhamrick added this to the 0.6.0 milestone Feb 18, 2018
@jhamrick jhamrick force-pushed the use-firefox branch 2 times, most recently from a84b5de to e4477ca Compare February 18, 2018 19:08
@jhamrick
Copy link
Member Author

jhamrick commented May 7, 2018

So this has turned out to be way more annoying of a change than I anticipated. In particular, it seems the most annoying thing is that Firefox appears to leak memory as more tests are run. For test_formgrade.py, this is particularly bad since there are a lot of tests and before it even gets halfway through all the tests it is eating up 1GB of memory. I modified the browser fixture so that it closes and reopens Firefox after every test which forces the memory to be freed, but then this makes the tests take 2x as long to run 😞

There are also still some tests that are flaky, like test_load_live_notebook and test_next_prev_assignments in test_formgrade.py. I can't seem to reproduce the failure of test_load_live_notebook locally, and while I can sometimes reproduce test_next_prev_assignments, I cannot determine why it is failing. I suspect there is a problem with the keypresses being sent before the javascript is fully loaded, but Firefox can't capture javascript logs so I cannot isolate the problem 😠

@jhamrick jhamrick merged commit ae11a73 into jupyter:master May 8, 2018
@jhamrick jhamrick deleted the use-firefox branch May 8, 2018 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out what to do about running nbextension tests
1 participant