Set nbgrader url prefix to be relative to notebook_dir #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamrick
force-pushed
the
rel-notebook-dir
branch
from
8d72a98 to
de47073
Compare
jhamrick
force-pushed
the
rel-notebook-dir
branch
from
de47073 to
363086a
Compare
jhamrick
added a commit
to jhamrick/nbgrader
that referenced
this pull request
Aug 12, 2017
…tebook_dir Fixes jupyter#855 Ping @mpacer -- it was in fact this line causing the issue! I needed to change the url to be relative to the notebook directory, rather than the current directory (which defaults to the user's home directory).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #855
Ping @mpacer -- it was in fact this line causing the issue! I needed to change the url to be relative to the notebook directory, rather than the current directory (which defaults to the user's home directory).