Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catches for empty timestamp files and invalid timestamp strings #585

Merged
merged 3 commits into from
Dec 16, 2016

Conversation

lgpage
Copy link
Member

@lgpage lgpage commented Dec 15, 2016

closes #580

@jhamrick
Copy link
Member

Awesome, thanks!! 🎉

Needs rebase since I merged the other PR fixing the tests, but I think this should be good to merge after that and the tests all pass.

@jhamrick jhamrick added this to the 0.4.0 milestone Dec 15, 2016
@lgpage
Copy link
Member Author

lgpage commented Dec 15, 2016

Done. All tests are happy 😄

@jhamrick jhamrick merged commit 4f16e35 into jupyter:master Dec 16, 2016
@jhamrick
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling empty timestamps
2 participants