Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official HubAuth from JupyterHub #538

Merged
merged 4 commits into from
Sep 8, 2016
Merged

Conversation

jhamrick
Copy link
Member

Fixes #520

cc @minrk -- no need for review or anything, I just wanted to let you know I've finally done this! I ended up not using the tornado mixin because my handlers aren't always authenticated with JupyterHub. But I am now using jupyterhub.services.auth.HubAuth rather than my own thing.

@jhamrick jhamrick added this to the 0.4.0 milestone Aug 27, 2016
@minrk
Copy link
Member

minrk commented Aug 29, 2016

Great! Since you are the first user of this outside the single-user server itself, I'd be happy for some feedback if there's anything that should be better.

@jhamrick
Copy link
Member Author

I think for the most part it works pretty well. One suggestion might be to have the default login url just be '/hub/login' (rather that including the full url at the beginning) because otherwise the ?next=... redirection doesn't work (since JupyterHub will refuse absolute redirects, only relative ones).

@minrk
Copy link
Member

minrk commented Aug 30, 2016

Great, thanks. I think that's something to fix on both ends - the redirect filter should recognize its own URL.

@jhamrick jhamrick merged commit 6e57600 into jupyter:master Sep 8, 2016
@jhamrick jhamrick deleted the hubauth branch September 8, 2016 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants