Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the mit license link #1940

Closed
wants to merge 1 commit into from
Closed

Fix the mit license link #1940

wants to merge 1 commit into from

Conversation

brichet
Copy link
Contributor

@brichet brichet commented Nov 15, 2024

No description provided.

Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/nbgrader/fix_links

@lahwaacz
Copy link
Contributor

The LICENSE file is BSD-3-Clause, not MIT, though...

@brichet
Copy link
Contributor Author

brichet commented Nov 15, 2024

The LICENSE file is BSD-3-Clause, not MIT, though...

It is the license of a component used in formgrader.

@lahwaacz
Copy link
Contributor

It is the license of a component used in formgrader.

Hmm what is the upstream of the component? Why do you update in this git repo? The top-level LICENSE file should still apply to the whole repo, but in this case it doesn't - a classical issue of a monorepo...

@brichet
Copy link
Contributor Author

brichet commented Nov 18, 2024

I agree, the choice of embedding javascript libraries seems to date back to the origins. Some notes about it in the doc: https://nbgrader.readthedocs.io/en/latest/contributor_guide/js_dependencies.html

We should probably get rid of these committed dependencies. But we should also avoid using bower as package management for the formgrader frontend, it is now unmaintained.

I'm closing this PR since it doesn't solve the problem anyway.

@brichet brichet closed this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants