Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed LaTeX rendering in some demo notebooks #1890

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

ZiadAmerr
Copy link
Contributor

The current notebooks are incorrectly rendered because the dollar sign should not be perceded by a space to be rendered correctly in Visual Studio Code cells, adding a space around them fixes the problem, however it does render correctly on GitHub.

The part in red is the default format, the part in green is the fixed format.
Screenshot 2024-06-14 at 5 54 17 PM

The current notebooks are incorrectly rendered because the dollar sign should not be perceded by a space to be rendered correctly in Visual Studio Code cells, adding a space around them fixes the problem, however it does render correctly on GitHub
Copy link
Contributor

Binder 👈 Launch a Binder on branch ZiadAmerr/nbgrader/main

@brichet
Copy link
Contributor

brichet commented Jun 18, 2024

Thanks @ZiadAmerr.
Can you rebase on main please, to make sure the tests pass ?

Copy link
Contributor

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @ZiadAmerr

I just added a missing one.

Co-authored-by: Nicolas Brichet <[email protected]>
@brichet brichet merged commit f3878c7 into jupyter:main Jun 20, 2024
24 checks passed
@ZiadAmerr
Copy link
Contributor Author

You're welcome @brichet :)

AlirezaT99 pushed a commit to AaltoSciComp/nbgrader that referenced this pull request Aug 6, 2024
* Fixed LaTeX rendering in some demo notebooks

The current notebooks are incorrectly rendered because the dollar sign should not be perceded by a space to be rendered correctly in Visual Studio Code cells, adding a space around them fixes the problem, however it does render correctly on GitHub

* Updated required fix

Co-authored-by: Nicolas Brichet <[email protected]>

---------

Co-authored-by: Nicolas Brichet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants