Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of deprecated typing.io #1855

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

shreve
Copy link
Contributor

@shreve shreve commented Jan 3, 2024

The typing.io namespace was deprecated in python 3.8, which is the lowest version currently supported by nbgrader.

https://docs.python.org/3/library/typing.html#aliases-to-other-concrete-types

The typing.io namespace was deprecated in python 3.8, which is the
lowest version currently supported by nbgrader.

https://docs.python.org/3/library/typing.html#aliases-to-other-concrete-types
Copy link
Contributor

github-actions bot commented Jan 3, 2024

Binder 👈 Launch a Binder on branch shreve/nbgrader/remove-deprecated-alias

Copy link
Contributor

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @shreve

@brichet brichet merged commit 720299d into jupyter:main Mar 28, 2024
25 of 26 checks passed
@shreve shreve deleted the remove-deprecated-alias branch April 3, 2024 16:30
AlirezaT99 pushed a commit to AaltoSciComp/nbgrader that referenced this pull request Aug 6, 2024
The typing.io namespace was deprecated in python 3.8, which is the
lowest version currently supported by nbgrader.

https://docs.python.org/3/library/typing.html#aliases-to-other-concrete-types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants