Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix labextension plugin IDs in the docs #1811

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Conversation

lahwaacz
Copy link
Contributor

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch lahwaacz/nbgrader/fix-docs

@brichet
Copy link
Contributor

brichet commented Aug 14, 2023

Fixes also #1810

@brichet
Copy link
Contributor

brichet commented Aug 14, 2023

Thanks @lahwaacz.

There is also one plugin name not updated in the demos (the other ones have been updated already). Can you fix it in this PR ?

jupyter labextension enable --level=sys_prefix nbgrader/validate_assignment

@lahwaacz
Copy link
Contributor Author

@brichet Done.

@lahwaacz
Copy link
Contributor Author

@brichet Some UI tests failed, but I don't think that's my fault. Can you help?

@brichet
Copy link
Contributor

brichet commented Aug 17, 2023

@brichet Some UI tests failed, but I don't think that's my fault. Can you help?

This is related to a broken version of jupyterlab/galata (the test helper) in jupyterlab==4.0.4 and jupyterlab==4.0.5.
https://github.com/jupyterlab/jupyterlab/releases/tag/v4.0.5

I'll see how to fix it.

@brichet
Copy link
Contributor

brichet commented Aug 18, 2023

@brichet Some UI tests failed, but I don't think that's my fault. Can you help?

#1812 should fix it.
Can you try rebasing ?

@lahwaacz

@lahwaacz
Copy link
Contributor Author

@brichet Sure, rebased.

@brichet
Copy link
Contributor

brichet commented Aug 18, 2023

Thanks @lahwaacz

@brichet brichet merged commit a81aa54 into jupyter:main Aug 18, 2023
@brichet brichet changed the title Fix labextension plutin IDs in the docs Fix labextension plugin IDs in the docs Sep 4, 2023
shreve pushed a commit to shreve/nbgrader that referenced this pull request Jul 8, 2024
* Fix labextension plugin IDs in the docs

* Fix validate-assignment labextension plugin ID in the demos
AlirezaT99 pushed a commit to AaltoSciComp/nbgrader that referenced this pull request Aug 6, 2024
* Fix labextension plugin IDs in the docs

* Fix validate-assignment labextension plugin ID in the demos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants