Toggle visibility of all student names #1775
Conversation
|
|
|
Failures are timeouts. They seem unrelated to me |
|
|
There was a problem hiding this comment.
Thanks @tuncbkose.
I have some comments on the PR.
Also, can you add test for Notebook and Jupyterlab ?
| @@ -187,6 +187,20 @@ var loadSubmittedNotebooks = function () { | |||
| }); | |||
| }; | |||
|
|
|||
| // button to toggle all student names | |||
| var names_hidden = true; | |||
There was a problem hiding this comment.
If all the names have already been displayed using the eye icons, clicking on the button will do nothing the first time.
Maybe instead of a global variable we could check in the function if some names are hidden.
There was a problem hiding this comment.
I changed the logic so that the button label is updated properly when pressing individual eye icons. The button's logic then depends on its label.
nbgrader/server_extensions/formgrader/templates/gradebook_notebook_submissions.tpl
Outdated
Show resolved
Hide resolved
nbgrader/server_extensions/formgrader/static/js/gradebook_notebook_submissions.js
Outdated
Show resolved
Hide resolved
|
On a related note, for the Lab 4 tests, would the tests work immediately? If needed, I can take a look into that pull request and prepare something that will work. |
Thanks, I'll do it for this test. |
* toggle visibility of all student names * Add toggle names button tests
Adds a new button in gradebook_notebook_submissions view to toggle visibility of all student names, closes #951.