Make hashing independent of notebook content #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I like this solution and would also solve some of the issues I am facing! |
brichet
reviewed
Jun 18, 2024
There was a problem hiding this comment.
Thanks @tuncbkose, let's move forward and merge this one.
Can you rebase on main please ?
|
Thanks for the review. I'll rebase within a day or two and ping you |
Decouple notebook hash from its content
|
@brichet rebased. |
|
Thanks @tuncbkose |
|
Happy to see this. 🎉 Was manually applying the PR every update. Thanks @tuncbkose |
AlirezaT99
pushed a commit
to AaltoSciComp/nbgrader
that referenced
this pull request
Aug 6, 2024
* Make hashing independent of notebook content Decouple notebook hash from its content * Testing changes for hash changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, changing the content of a submitted notebook breaks feedback distribution (see some discussion in #1202). This is because feedback distribution uses a hash that depends on the notebook content.
This pr aims to solve this issue by duplicating the
timestamp.txtmechanism. Asubmission_secret.txtfile containing a random string is created during submission, and the notebook hash is changed to depend only on this file and notebook name.Should fix #1712