Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blank tab names and labextension button label #1756

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Fix blank tab names and labextension button label #1756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b99883
Fix blank tab names
tuncbkose Mar 21, 2023
685e36a
Fix button label
tuncbkose Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/assignment_list/assignmentlist.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ class Assignment {
var that = this;
if (this.data['status'] === 'released') {

button.innerText = "fetch";
button.innerText = "Fetch";
button.onclick = async function(){
button.innerText = 'Fetching...';
button.setAttribute('disabled', 'disabled');
Expand Down
2 changes: 1 addition & 1 deletion src/assignment_list/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ export const assignment_list_extension: JupyterFrontEndPlugin<void> = {
app.commands.addCommand(command,{
label: 'Assignment List',
execute: () => {
if(!widget){
if(!widget || widget.isDisposed){
const content = new AssignmentListWidget(app);
widget = new MainAreaWidget({content});
widget.id = 'nbgrader-assignment-list';
Expand Down
2 changes: 1 addition & 1 deletion src/course_list/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export const course_list_extension: JupyterFrontEndPlugin<void> = {
app.commands.addCommand(command, {
label: 'Course List',
execute: () => {
if (!widget) {
if (!widget || widget.isDisposed) {
const content = new CourseListWidget(app);
widget = new MainAreaWidget({content});
widget.id = 'nbgrader-course-list'
Expand Down
2 changes: 1 addition & 1 deletion src/formgrader/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export const formgrader_extension: JupyterFrontEndPlugin<void> = {
app.commands.addCommand(command,{
label: 'Formgrader',
execute: async args => {
if(!widget){
if(!widget || widget.isDisposed){
const settings = ServerConnection.makeSettings();
const url = (args.url as string) || URLExt.join(settings.baseUrl, "formgrader");

Expand Down