Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for testing CI #1737

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Conversation

tuncbkose
Copy link
Contributor

This pr fixes a broken link in the docs and updates node-canvas so that a binary is actually available.

A testing error caused by JupyterLab Announcement extension remains unfixed because I don't know what is the best way to disable that (isolated to the testing process).

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch AaltoSciComp/nbgrader/testfix-for-upstream

@brichet brichet added bug bugfix dependencies Python dependencies labels Feb 28, 2023
@tuncbkose
Copy link
Contributor Author

tuncbkose commented Feb 28, 2023

The cancellations are all timeouts (which is also present in other recent prs) and the labextension fails are due to the announcement extension, so no surprises there.

I don't really understand how check_release works yet, so I am not sure why it is failing.
The check_release failure seems to be codecov.io links hanging, so is independent of this pr.

@brichet
Copy link
Contributor

brichet commented Mar 2, 2023

Thanks @tuncbkose, the tests that fail are indeed not related

@brichet brichet merged commit e9b4fee into jupyter:main Mar 2, 2023
@tuncbkose tuncbkose deleted the testfix-for-upstream branch March 3, 2023 06:51
@brichet
Copy link
Contributor

brichet commented Mar 3, 2023

Fixes a part of #1736

@brichet brichet mentioned this pull request Mar 3, 2023
@brichet brichet requested review from brichet and removed request for brichet March 6, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Python dependencies maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants