Fix view feedback link when root_dir is set #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@meeseeksdev backport to 0.7.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/nbgrader
that referenced
this pull request
Sep 30, 2022
brichet
added a commit
to meeseeksmachine/nbgrader
that referenced
this pull request
Sep 30, 2022
|
I can confirm this branch works for my docker notebook images, which are deployed in a K8s cluster. |
brichet
force-pushed
the
fix/view_feedback
branch
2 times, most recently
from
11afd3c to
e294527
Compare
brichet
force-pushed
the
fix/view_feedback
branch
from
e294527 to
ac5a6f1
Compare
brichet
added a commit
that referenced
this pull request
Dec 30, 2022
brichet
force-pushed
the
fix/view_feedback
branch
from
ac5a6f1 to
a31a510
Compare
brichet
force-pushed
the
fix/view_feedback
branch
from
a31a510 to
4fe1c19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
view feedbacklink does not work when theroot_dirof JupyterLab is different from './'.The reason is that the feedback path is not relative to the
root_dirbut to the directory where nbgrader started.This PR solves the problem by changing the feedback path to a relative path from
root_dir.I observed the same issue with classic notebook (in version
0.7.x) if thenotebook_pathis different from './'.This PR should probably be back ported to
0.7.xbranch.Close #1664