Add maximum size for entire directory as submission option #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rkdarst
approved these changes
Jan 11, 2023
| @@ -231,7 +232,7 @@ def test_submit_include(self, exchange, cache, course_dir): | |||
| filename, = os.listdir(join(exchange, "abc101", "inbound")) | |||
| assert not exists(join(exchange, "abc101", "inbound", filename, "foo.txt")) | |||
|
|
|||
| def test_submit_include(self, exchange, cache, course_dir): | |||
There was a problem hiding this comment.
This is renamed since it's the same name as above - it was probably named wrong.
Gehock
force-pushed
the
limit-submission-directory-size
branch
from
2cd6b12 to
8f2a071
Compare
Gehock
force-pushed
the
limit-submission-directory-size
branch
from
8f2a071 to
888b9a1
Compare
The previous maximum size option was applied to individual files only. This adds a separate option to limit the maximum size of the entire directory. The option is called max_dir_size and is implemented similarly to max_file_size. The default is no maximum directory size limit.
Gehock
force-pushed
the
limit-submission-directory-size
branch
from
888b9a1 to
783a3c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous maximum size option was applied to individual files only. This adds a separate option to limit the maximum size of the entire directory. The option is called max_dir_size and is implemented similarly to max_file_size. The default is same as the max file size.