-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only add extra_template_basedirs if it has not been set #1579
Conversation
Thanks @tmetzl ! Can you modify this to merge into master rather than 0.7.x? I think you just would need to cherry-pick your commit (so it excludes the 'Bump version to 0.7.1.dev' commit). |
@jhamrick I think I messed by dropping the commit. Should I create a new clean PR in favor of this one? |
I was able to fix it! 😄 (If you're curious, here are the git commands I used to do it)
|
Perfect 👍 |
Tests are passing locally, so should be good to merge. |
@meeseeksdev backport to 0.7.x |
…9-on-0.7.x Backport PR #1579 on branch 0.7.x (Only add extra_template_basedirs if it has not been set)
In nbgrader v0.6.x we only set the
template_path
option if it is not already in the config (see here).In nbgrader v0.7.x we should also only set the the
extra_template_basedirs
conditionally in order to not break any custom exporters.