Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump traitlets from 4.3.3 to 5.0.5 #1442

Merged
merged 3 commits into from
May 5, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix bug with duplicate hist_file
jhamrick committed May 5, 2021
commit df99a679ab002ec000fe33cb640ff59ff7a5f9a3
5 changes: 5 additions & 0 deletions nbgrader/preprocessors/execute.py
Original file line number Diff line number Diff line change
@@ -38,6 +38,11 @@ def preprocess(self,
resources: ResourcesDict,
retries: Optional[Any] = None
) -> Tuple[NotebookNode, ResourcesDict]:
# This gets added in by the parent execute preprocessor, so if it's already in our
# extra arguments we need to delete it or traitlets will be unhappy.
if '--HistoryManager.hist_file=:memory:' in self.extra_arguments:
self.extra_arguments.remove('--HistoryManager.hist_file=:memory:')

if retries is None:
retries = self.execute_retries