Validate pre and post convert hooks #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamrick
requested changes
May 5, 2021
nbgrader/converters/base.py
Outdated
| @validate('post_convert_hook') | ||
| def _validate_post_convert_hook(self, proposal): | ||
| value = proposal['value'] | ||
| if isinstance(value, string_types): |
There was a problem hiding this comment.
nbgrader is python 3 only these days, so I think you can just check against str here (and above as well).
nbgrader/converters/base.py
Outdated
| @@ -19,6 +19,8 @@ | |||
| from ..nbgraderformat import SchemaTooOldError, SchemaTooNewError | |||
| import typing | |||
| from nbconvert.exporters.exporter import ResourcesDict | |||
| from ipython_genutils.importstring import import_item | |||
There was a problem hiding this comment.
I believe genutils isn't officially supported, and it would probably be better to not need to add a new dependency in any case---could you achieve the same behavior using importlib.import_module? See https://docs.python.org/3/library/importlib.html
|
Thanks for pointing out the changes. I think I addressed them with my new commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the problem mentioned in #1376.
If the hooks are given as an import string (see example) they are now properly imported.