Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make converter exporter class configurable #1437

Merged
merged 1 commit into from
May 3, 2021
Merged

Make converter exporter class configurable #1437

merged 1 commit into from
May 3, 2021

Conversation

tmetzl
Copy link
Contributor

@tmetzl tmetzl commented May 3, 2021

This allows users to set a custom exporter class in each converter.

Use case:
We want to enrich student feedback with custom information and need custom filters for this. The easiest way to achieve this is is by using a custom exporter as the GenerateFeedback converter.

Any comments are appreciated.

@jhamrick jhamrick added this to the 0.7.0 milestone May 3, 2021
Copy link
Member

@jhamrick jhamrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, thanks!

@jhamrick jhamrick merged commit 899f342 into jupyter:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants