Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix migrations. #1384

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Fix migrations. #1384

merged 1 commit into from
Nov 9, 2020

Conversation

BertR
Copy link
Contributor

@BertR BertR commented Oct 27, 2020

The old code behaviour raises an error in SQLAlchemy 1.3.20 and up.
Fixes #1383

@BertR BertR added the bugfix label Oct 27, 2020
@BertR BertR requested a review from jhamrick October 27, 2020 13:28
@BertR
Copy link
Contributor Author

BertR commented Oct 27, 2020

The pipeline for Python 3.8 on Windows 10, because the output of "python -m nbgrader --version" differs in
some way from the output on Python 3.7, but I have no access to a Windows machine at this time to check.

@BertR BertR merged commit 3aa5af2 into jupyter:master Nov 9, 2020
@BertR BertR added this to the 0.6.2 milestone Mar 16, 2021
BertR added a commit that referenced this pull request Mar 16, 2021
@BertR
Backport PR #1384: Fix migrations.
98da08c 
The old code behaviour raises an error in SQLAlchemy 1.3.20 and up.
Fixes #1383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamrick jhamrick Awaiting requested review from jhamrick

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
0.6.2
Development

Successfully merging this pull request may close these issues.

Nbgrader migrations break with SQLAlchemy 1.3.20
1 participant
@BertR