Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin nbconvert to 5.6.1, traitlets to 4.3.3 and pytest to <6.0.0 #1369

Merged
merged 3 commits into from
Sep 15, 2020
Merged

Pin nbconvert to 5.6.1, traitlets to 4.3.3 and pytest to <6.0.0 #1369

merged 3 commits into from
Sep 15, 2020

Conversation

BertR
Copy link
Contributor

@BertR BertR commented Sep 15, 2020

Fixes #1367

@BertR BertR changed the title Pin nbconvert to 5.6.1 Pin nbconvert to 5.6.1, traitlets to 4.3.3 and pytest to <6.0.0 Sep 15, 2020
@BertR BertR merged commit 5a6f5fc into jupyter:master Sep 15, 2020
@rkdarst
Copy link
Contributor

rkdarst commented Jan 11, 2021

Is there documentation for why the other pins were made, or is it a generic something broke without deeper investigation at the time?

@BertR
Copy link
Contributor Author

BertR commented Jan 12, 2021

Is there documentation for why the other pins were made, or is it a generic something broke without deeper investigation at the time?

It was definitely the latter. I would welcome any PRs that would let us upgrade the dependencies. Is this something you could look at @rkdarst ?

@rkdarst
Copy link
Contributor

rkdarst commented Jan 12, 2021

I submitted the forward-port to nbconvert 6.0 which so far seems working, #1405

Interestingly, I am running with traitlets 5.0.5 and it seems to work now. Maybe it was an upstream problem that got fixed since then? (though my fork is based on upstream 4c5d6f6, so the nbgrader-incompatible part could have been )

No info on pytest yet, but I haven't had much luck running the tests at all...

@rkdarst rkdarst mentioned this pull request Feb 9, 2021
Closed
@BertR BertR added this to the 0.6.2 milestone Mar 16, 2021
BertR added a commit that referenced this pull request Mar 16, 2021
@BertR
Backport PR #1369: Pin nbconvert to 5.6.1, traitlets to 4.3.3 and pyt…
712de0d 
…est to <6.0.0

Fixes #1367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix maintenance
Projects
None yet
Milestone
0.6.2
Development

Successfully merging this pull request may close these issues.

nbconvert version 6.0.0 breaks nbgrader feedback
2 participants
@BertR @rkdarst